From 76416c459c6e0b3579c5177df414e0633b8b9565 Mon Sep 17 00:00:00 2001 From: Roger Pau Monne Date: Fri, 13 Mar 2020 09:45:58 +0100 Subject: [PATCH] libfsimage: fix parentheses in macro parameters MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit VERIFY_DN_TYPE and VERIFY_OS_TYPE should use parentheses when accessing the type parameter. Note that none of the current usages require this, it's just done for correctness. Signed-off-by: Roger Pau Monné Acked-by: Wei Liu --- tools/libfsimage/zfs/fsys_zfs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libfsimage/zfs/fsys_zfs.h b/tools/libfsimage/zfs/fsys_zfs.h index 721972a05a..b4be51b50d 100644 --- a/tools/libfsimage/zfs/fsys_zfs.h +++ b/tools/libfsimage/zfs/fsys_zfs.h @@ -71,7 +71,7 @@ typedef unsigned int size_t; * Can only be used in functions returning non-0 for failure. */ #define VERIFY_DN_TYPE(dnp, type) \ - if (type != DMU_OT_NONE && (dnp)->dn_type != type) { \ + if ((type) != DMU_OT_NONE && (dnp)->dn_type != (type)) { \ return (ERR_FSYS_CORRUPT); \ } @@ -80,7 +80,7 @@ typedef unsigned int size_t; * Can only be used in functions returning 0 for failure. */ #define VERIFY_OS_TYPE(osp, type) \ - if (type != DMU_OST_NONE && (osp)->os_type != type) { \ + if ((type) != DMU_OST_NONE && (osp)->os_type != (type)) { \ errnum = ERR_FSYS_CORRUPT; \ return (0); \ } -- 2.30.2